[PATCH v1 8/8] [WIP] ipa: enable debug metadata by default

Stefan Klug stefan.klug at ideasonboard.com
Wed Oct 2 18:19:26 CEST 2024


Camshark currently doesn't support metadata values that are not there on
every frame. Enable the debug metadata by default to test this series.

Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
---
 src/ipa/rkisp1/rkisp1.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
index 5b1ef0c372c6..fc95f733a2e8 100644
--- a/src/ipa/rkisp1/rkisp1.cpp
+++ b/src/ipa/rkisp1/rkisp1.cpp
@@ -328,6 +328,11 @@ void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)
 {
 	IPAFrameContext &frameContext = context_.frameContexts.alloc(frame);
 	context_.debugMetadata.checkForEnable(controls);
+	/*
+	 * Todo: Remove the unconditional enable as soon as camshark supports
+	 * metadata that is not available on every frame
+	 */
+	context_.debugMetadata.enable();
 
 	for (auto const &a : algorithms()) {
 		Algorithm *algo = static_cast<Algorithm *>(a.get());
-- 
2.43.0



More information about the libcamera-devel mailing list