[PATCH v1 8/8] [WIP] ipa: enable debug metadata by default

[Laurent Pinchart]

Hi Stefan,

Thank you for the patch.

On Wed, Oct 02, 2024 at 06:19:26PM +0200, Stefan Klug wrote:
> Camshark currently doesn't support metadata values that are not there on
> every frame. Enable the debug metadata by default to test this series.

Patches that are temporary and not meant for integration can be marked
with [DNI] (which stands for Do Not Integrate) instead of [WIP].

> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>

I won't provide a R-b tag as this shouldn't be merged :-)

> ---
>  src/ipa/rkisp1/rkisp1.cpp | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index 5b1ef0c372c6..fc95f733a2e8 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -328,6 +328,11 @@ void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)
>  {
>  	IPAFrameContext &frameContext = context_.frameContexts.alloc(frame);
>  	context_.debugMetadata.checkForEnable(controls);
> +	/*
> +	 * Todo: Remove the unconditional enable as soon as camshark supports
> +	 * metadata that is not available on every frame
> +	 */
> +	context_.debugMetadata.enable();
>  
>  	for (auto const &a : algorithms()) {
>  		Algorithm *algo = static_cast<Algorithm *>(a.get());

-- 
Regards,

Laurent Pinchart