RFC: API change: Make CameraManager provide a list of CameraDescription objects

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Sep 2 22:29:34 CEST 2024


Hi Milan,

On Mon, Sep 02, 2024 at 11:06:17AM +0200, Milan Zamazal wrote:
> Hans de Goede <hdegoede at redhat.com> writes:
> 
> > <somewhat offtopic>
> >
> > Actually my "could really use some help wrt someone reviewing" remark was
> > not targeted at you (Laurent). I was trying to stimulate others to do
> > more reviewing. Having you do all the reviews does not scale.
> 
> Yes.  The problem is that with the highly skilled people around (both
> the posters and reviewers) and the knowledge required (libcamera design,
> kernel, sensors, advanced C++, ...) I often think about the
> contribution/noise ratio my review would bring.  To deal with this, I
> try to review at least all what touches software ISP and to watch other
> reviews to learn from them.

I've noticed that, and I'm very grateful. Patches are appreciated, and
reviews are as well, equally if not more.

> > Actually this is also something where I want to do better myself. E.g.
> > I should be able to review Milan's software ISP cleanup series. 
> 
> Hint: Several people have already helped with reviewing the series.
> As of v5, patches still missing any reviews are #7 and #15-18.
> 
> > But atm my priorities are at closing bugs in pipewire video/libcamera
> > support before these ship to end users in Fedora 41.
> 
> That's certainly very important and thank you for working on that.
> 
> > Once that is done I'll hopefully have some bandwidth to help out with
> > reviews.
> 
> Thank you.
> 
> > </somewhat offtopic>

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list