[PATCH] pipeline: rkisp1: Fix vblank delay
Kieran Bingham
kieran.bingham at ideasonboard.com
Mon Apr 21 11:40:08 CEST 2025
Quoting Paul Elder (2025-04-21 07:49:59)
> The vblank delay for delayed controls was incorrectly hardcoded to 1.
> Get it from the camera sensor properties instead.
>
> Fixes: f72c76eb6e06 ("rkisp1: Honor the FrameDurationLimits control")
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 52633fe3cb85..194dfce7ee5d 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -1325,7 +1325,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)
> std::unordered_map<uint32_t, DelayedControls::ControlParams> params = {
> { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },
> { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },
> - { V4L2_CID_VBLANK, { 1, false } },
> + { V4L2_CID_VBLANK, { delays.vblankDelay, false } },
> };
>
> data->delayedCtrls_ =
> --
> 2.47.2
>
More information about the libcamera-devel
mailing list