[PATCH] pipeline: rkisp1: Fix vblank delay

[Laurent Pinchart]

Hi Paul,

Thank you for the patch.

On Mon, Apr 21, 2025 at 03:49:59PM +0900, Paul Elder wrote:
> The vblank delay for delayed controls was incorrectly hardcoded to 1.
> Get it from the camera sensor properties instead.
> 
> Fixes: f72c76eb6e06 ("rkisp1: Honor the FrameDurationLimits control")
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 52633fe3cb85..194dfce7ee5d 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -1325,7 +1325,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)
>  	std::unordered_map<uint32_t, DelayedControls::ControlParams> params = {
>  		{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },
>  		{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },
> -		{ V4L2_CID_VBLANK, { 1, false } },
> +		{ V4L2_CID_VBLANK, { delays.vblankDelay, false } },
>  	};
>  
>  	data->delayedCtrls_ =

-- 
Regards,

Laurent Pinchart