[PATCH v2 2/4] apps: cam: sdl_texture: Drop `&rect_` from `SDL_Update{NV, }Texture()` call
Kieran Bingham
kieran.bingham at ideasonboard.com
Fri Apr 25 14:02:10 CEST 2025
Quoting Barnabás Pőcze (2025-04-25 11:47:01)
> If the entire texture is to be updated, there is no need to specify
> the target area explicitly.
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze at ideasonboard.com>
> ---
> src/apps/cam/sdl_texture_yuv.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp
> index 80a5ec05d..7e2ce3f49 100644
> --- a/src/apps/cam/sdl_texture_yuv.cpp
> +++ b/src/apps/cam/sdl_texture_yuv.cpp
> @@ -17,7 +17,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)
>
> void SDLTextureNV12::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)
> {
> - SDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,
> + SDL_UpdateNVTexture(ptr_, nullptr, data[0].data(), stride_,
> data[1].data(), stride_);
> }
> #endif
> @@ -29,5 +29,5 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)
>
> void SDLTextureYUYV::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)
> {
> - SDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);
> + SDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);
> }
> --
> 2.49.0
>
More information about the libcamera-devel
mailing list