[PATCH v2 2/4] apps: cam: sdl_texture: Drop `&rect_` from `SDL_Update{NV, }Texture()` call

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Apr 25 14:35:39 CEST 2025


Hi Barnabás,

Thank you for the patch.

On Fri, Apr 25, 2025 at 12:47:01PM +0200, Barnabás Pőcze wrote:
> If the entire texture is to be updated, there is no need to specify
> the target area explicitly.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/apps/cam/sdl_texture_yuv.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp
> index 80a5ec05d..7e2ce3f49 100644
> --- a/src/apps/cam/sdl_texture_yuv.cpp
> +++ b/src/apps/cam/sdl_texture_yuv.cpp
> @@ -17,7 +17,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)
>  
>  void SDLTextureNV12::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)
>  {
> -	SDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,
> +	SDL_UpdateNVTexture(ptr_, nullptr, data[0].data(), stride_,
>  			    data[1].data(), stride_);
>  }
>  #endif
> @@ -29,5 +29,5 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)
>  
>  void SDLTextureYUYV::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)
>  {
> -	SDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);
> +	SDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);
>  }

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list