[PATCH v7 08/12] controls: Remove AeLocked
Stefan Klug
stefan.klug at ideasonboard.com
Mon Jan 13 11:45:17 CET 2025
Hi Jacopo, hi Paul,
Thank you for the patch.
On Fri, Jan 10, 2025 at 05:57:33PM -0600, Paul Elder wrote:
> From: Jacopo Mondi <jacopo at jmondi.org>
>
> Now that the codebase has been ported to use the new AEGC controls
> remove the definition of AeLocked. AeEnable is not be removed as it will
> be redefined.
>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com>
Cheers,
Stefan
>
> ---
> No change in v7
>
> Changes in v6:
> - remove only AeLocked, as AeEnable will be redefined instead of removed
> - (used to be "controls: Remove AeEnable and AeLocked")
>
> No change in v5
>
> No change in v4
>
> No change in v3
> ---
> src/libcamera/control_ids_core.yaml | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml
> index 553095481..d88c1852e 100644
> --- a/src/libcamera/control_ids_core.yaml
> +++ b/src/libcamera/control_ids_core.yaml
> @@ -16,18 +16,6 @@ controls:
>
> \sa ExposureTime AnalogueGain
>
> - - AeLocked:
> - type: bool
> - direction: out
> - description: |
> - Report the lock status of a running AE algorithm.
> -
> - If the AE algorithm is locked the value shall be set to true, if it's
> - converging it shall be set to false. If the AE algorithm is not
> - running the control shall not be present in the metadata control list.
> -
> - \sa AeEnable
> -
> - AeState:
> type: int32_t
> direction: out
> --
> 2.39.2
>
More information about the libcamera-devel
mailing list