[PATCH] pipeline: rkisp1: Log tuning file path

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Jan 23 15:47:52 CET 2025


Hi Stefan,

Thank you for the patch.

On Wed, Jan 22, 2025 at 11:20:17AM +0100, Stefan Klug wrote:
> It is often helpful to know which tuning file gets used. Add a log
> statement with INFO level for that.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 35c793da9bba..e518be59c433 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -393,6 +393,8 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)
>  		ipaTuningFile = std::string(configFromEnv);
>  	}
>  
> +	LOG(RkISP1, Info) << "Using tuning file " << ipaTuningFile;
> +

I've just submitted "[PATCH] libcamera: pipeline: Move tuning file
override handling to IPAProxy". Would it make sense to move the logging
to the IPAProxy class ?

>  	IPACameraSensorInfo sensorInfo{};
>  	int ret = sensor_->sensorInfo(&sensorInfo);
>  	if (ret) {

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list