[PATCH] pipeline: rkisp1: Log tuning file path

[Stefan Klug]

Hi Laurent,

On Thu, Jan 23, 2025 at 04:47:52PM +0200, Laurent Pinchart wrote:
> Hi Stefan,
> 
> Thank you for the patch.
> 
> On Wed, Jan 22, 2025 at 11:20:17AM +0100, Stefan Klug wrote:
> > It is often helpful to know which tuning file gets used. Add a log
> > statement with INFO level for that.
> > 
> > Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> > ---
> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > index 35c793da9bba..e518be59c433 100644
> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > @@ -393,6 +393,8 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)
> >  		ipaTuningFile = std::string(configFromEnv);
> >  	}
> >  
> > +	LOG(RkISP1, Info) << "Using tuning file " << ipaTuningFile;
> > +
> 
> I've just submitted "[PATCH] libcamera: pipeline: Move tuning file
> override handling to IPAProxy". Would it make sense to move the logging
> to the IPAProxy class ?

Sure, I'll rebase it on top of yours.

Cheers,
Stefan

> 
> >  	IPACameraSensorInfo sensorInfo{};
> >  	int ret = sensor_->sensorInfo(&sensorInfo);
> >  	if (ret) {
> 
> -- 
> Regards,
> 
> Laurent Pinchart