[PATCH 00/10] libcamera: Enable -Wmissing-declarations
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Jun 24 21:29:31 CEST 2024
Hello,
This patch series enables -Wmissing-declarations to catch mismatches
between function declarations and definitions, which recently introduced
a bug in libcamera. Patch 01/10 to 09/10 first fix a (surprisingly
large) number of offenders that trigger the warning, and patch 10/10 the
enables it.
Laurent Pinchart (10):
libcamera: base: log: Declare log categories when defining them
ipa: ipa_interface: Declare ipaCreate() in libcamera namespace
ipa: rpi: Define local functions in anonymous namespace
py: libcamera: Move function declarations to common header
v4l2: v4l2_compat: Include missing headers
v4l2: v4l2_compat: Selectively disable -Wmissing-declarations
apps: Define local functions in anonymous namespace
test: ipc: unixsocket: Define local function in anonymous namespace
test: gstreamer: Include missing sanitizer/asan_interface.h header
meson: Enable warnings to flag missing declarations
include/libcamera/base/log.h | 1 +
include/libcamera/ipa/ipa_interface.h | 4 +-
meson.build | 1 +
src/apps/cam/main.cpp | 4 ++
src/apps/common/dng_writer.cpp | 6 ++-
src/apps/qcam/main.cpp | 4 ++
src/ipa/rpi/controller/rpi/ccm.cpp | 6 ++-
src/ipa/rpi/controller/rpi/contrast.cpp | 4 ++
src/py/libcamera/py_color_space.cpp | 2 +
src/py/libcamera/py_controls_generated.cpp.in | 2 +
src/py/libcamera/py_enums.cpp | 2 +
src/py/libcamera/py_formats_generated.cpp.in | 2 +
src/py/libcamera/py_geometry.cpp | 2 +
src/py/libcamera/py_main.cpp | 8 ----
src/py/libcamera/py_main.h | 10 +++++
.../libcamera/py_properties_generated.cpp.in | 2 +
src/py/libcamera/py_transform.cpp | 2 +
src/v4l2/v4l2_compat.cpp | 45 ++++++++++++-------
test/gstreamer/gstreamer_test.cpp | 6 +++
test/gstreamer/meson.build | 7 +++
test/ipc/unixsocket.cpp | 4 ++
21 files changed, 95 insertions(+), 29 deletions(-)
base-commit: 2119bdac6a011034cc33584e3303e47db4932313
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list