[PATCH v2 14/20] libcamera: ipa: Remove unused includes

Milan Zamazal mzamazal at redhat.com
Mon Sep 2 14:19:27 CEST 2024


Hi Laurent,

thank you for review.

Laurent Pinchart <laurent.pinchart at ideasonboard.com> writes:

> On Fri, Aug 30, 2024 at 05:27:11PM +0200, Milan Zamazal wrote:
>> The includes that are not used can be removed.
>> 
>
>> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
>> ---
>>  include/libcamera/ipa/ipa_interface.h | 5 -----
>>  1 file changed, 5 deletions(-)
>> 
>> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h
>> index 7c835e98..2fdc085e 100644
>> --- a/include/libcamera/ipa/ipa_interface.h
>> +++ b/include/libcamera/ipa/ipa_interface.h
>> @@ -7,11 +7,6 @@
>>  
>>  #pragma once
>>  
>> -#include <map>
>> -#include <stddef.h>
>> -#include <stdint.h>
>> -#include <vector>
>> -
>>  #include <libcamera/base/flags.h>
>>  #include <libcamera/base/signal.h>
>
> I think all the other includes can be dropped too.

I'm not sure.  ipa_interface.h is included in the generated files and
they rely on the includes (and what is worse, apparently on things
included through them).  Perhaps this should be fixed by including the
corresponding stuff at the right places but I'm worried by the fact that
LSP doesn't mark these includes as redundant (apparently for a reason).
I would rather not mess with the generated code in this patch series.



More information about the libcamera-devel mailing list